Discussion:
Source build breakage with system poppler-0.63
(too old to reply)
Ken Moffat
2018-04-03 23:22:28 UTC
Permalink
With last night's 2018-pre source (r47264) I got a new build failure
with system poppler because my latest system has moved to using
poppler-0.63.0. It turns out that Jerry James (Cc:'d) fixed this for
fedora rawhide's current 2017 build, but the changed code has moved a
lot further down the file in 2018.

His change is at https://src.fedoraproject.org/cgit/rpms/texlive-base.git/commit/texlive-20170520-new-poppler.patch?id=8f2dd7dbd55b013fa60f9138bdba648cc103bb80


diff -Naur a/texk/web2c/pdftexdir/pdftoepdf-newpoppler.cc b/texk/web2c/pdftexdir/pdftoepdf-newpoppler.cc
--- a/texk/web2c/pdftexdir/pdftoepdf-newpoppler.cc 2018-03-05 22:18:21.000000000 +0000
+++ b/texk/web2c/pdftexdir/pdftoepdf-newpoppler.cc 2018-04-03 22:19:43.326983429 +0100
@@ -968,8 +968,8 @@
*/
// begin modification
groupDict = pageDict->lookup("Group");
- Dict dic1 = page->getGroup();
- Dict dic2 = groupDict.getDict();
+ const Dict& dic1 = page->getGroup();
+ const Dict& dic2 = groupDict.getDict();
// replace dic2 in groupDict with dic1
l = dic2.getLength();
for (i = 0; i < l; i++) {

Build tested (plus the testsuite) on systems using poppler-0.62
(which had worked with the unpatched code) and 0.63.

ĸen
--
Before the universe began, there was a sound. It went: "One, two, ONE,
two, three, four" [...] The cataclysmic power chord that followed was
the creation of time and space and matter and it does Not Fade Away.
- wiki.lspace.org/mediawiki/Music_With_Rocks_In
Akira Kakuto
2018-04-04 04:18:34 UTC
Permalink
Post by Ken Moffat
With last night's 2018-pre source (r47264) I got a new build failure
with system poppler because my latest system has moved to using
poppler-0.63.0. It turns out that Jerry James (Cc:'d) fixed this for
fedora rawhide's current 2017 build, but the changed code has moved a
lot further down the file in 2018.
Thanks very much. Applied in r47281.

Best,
Akira

Loading...